Róbert Papp

Results 839 comments of Róbert Papp

``` java Glide.with(this).onDestroy(); ``` is the only thing I can think of right now.

I'm not sure how Glide will react when you go back to the fragment. It should re-load all the images, because you likely load them after `onCreateView`. Give it a...

I'm pretty sure @sjudd considered this. Have you @sjudd? Quickly, I don't think we can, because: 1. The tracker Fragment (that follows the lifecycle) doesn't have a view 2. Your...

@SiddarthG `this` can never be null (by Java specification). You can lose the reference to whatever `this` is if stored in a WeakReference in the AsyncTask, and the object GC'd...

Based on `ImageViewFactory` and the "dirty hack" in [`GlideDrawableImageViewTarget.onResourceReady`](https://github.com/bumptech/glide/blob/v3.5.2/library/src/main/java/com/bumptech/glide/request/target/GlideDrawableImageViewTarget.java#L63) I changed `into(image)` to `.into((Target)(Target)new DrawableImageViewTarget(image))`, and confirmed in debug that the target receives a `GlideBitmapDrawable`, but after that I wanted...

Long shot: since you have square placeholder I assume the space for the images isn't much wider, how about creating Drawable with the space's aspect (pad the square) and/or add...

master is 4.0, which has breaking changes and simplifications ``` java .apply(RequestOptions.placeholderOf(drawable)) //=.placeholder(drawable) ``` You don't need GlideDrawable, crossFade has to work between any two Drawables. Sam's link is still...

You shouldn't assume `BitmapDrawable`, I think it's possible to optimize for it, but a generic `Drawable` solution is needed anyway, so optimisation may not worth it. Assuming would break the...

In the above linked commit I found another way to work around this. It's not a full solution to this bug, but it works for placeholders that are smaller than...

@sheaam30 the issue is not closed; the simplest workaround is to have your placeholder and image aspect ratio match