grabbit icon indicating copy to clipboard operation
grabbit copied to clipboard

Upgrade to cq-gradle-plugins

Open jdigger opened this issue 10 years ago • 4 comments

  • https://github.com/TWCable/gradle-plugin-scr
  • https://github.com/TWCable/gradle-plugin-cq-bundle
  • https://github.com/TWCable/gradle-plugin-cq-package

jdigger avatar Jul 22 '15 20:07 jdigger

@jdigger Looks like it's been updated to cq-gradle-plugins 3.0.1 Is this issue more appropriate to update to the gradle-plugin split?

TWCable/gradle-plugin-cq-package TWCable/gradle-plugin-cq-bundle TWCable/gradle-plugin-scr TWCable/gradle-plugin-bundlor

pgoodrich avatar Jul 21 '16 20:07 pgoodrich

I had removed the "3.0" for being confusing, but it looks like it came back again...

In Grabbit's case, since it doesn't need to wrap 3rd party jars or use SCR annotations, it would be TWCable/gradle-plugin-cq-bundle and TWCable/gradle-plugin-cq-package

jdigger avatar Jul 21 '16 23:07 jdigger

Do we want bundlor for making upgrades like #42 easier? That way we wouldn't have to osgi wrap the jars and host them ourselves.

pgoodrich avatar Jul 22 '16 18:07 pgoodrich

Bundlor is used for wrapping the jars, so using it won't prevent the need to wrap and host 3rd-party jars.

Wrapping and hosting the jars is a nuisance, but not hard. An alternative is to embed them inside the Grabbit bundle. Because they would be inside the same classloader, they wouldn't need the OSGi metadata. Not exactly how OSGi is "meant" to be used, but an easy and practical solution.

jdigger avatar Jul 22 '16 19:07 jdigger