gocast icon indicating copy to clipboard operation
gocast copied to clipboard

Published 20 hours ago • verified publisher icon TUM-Dev

Remove Course.LiveEnabled

Open MatthiasReumann opened this issue 3 years ago • 5 comments

Changes

  • Closes #391
  • Updates testdata
  • Eliminates LiveEnabled from all places

Further information

SQL drop column command:

ALTER TABLE courses DROP COLUMN live_enabled;

MatthiasReumann avatar Aug 11 '22 07:08 MatthiasReumann

ALTER TABLE courses DROP COLUMN live_enabled;

This could be a migration

joschahenningsen avatar Aug 11 '22 08:08 joschahenningsen

ALTER TABLE courses DROP COLUMN live_enabled;

This could be a migration

I've added the migration. I hope I got the naming right 😅 How do I make sure that the migrations executes - or in other words - where do I call the migration?

MatthiasReumann avatar Aug 11 '22 09:08 MatthiasReumann

You can reference it here https://github.com/joschahenningsen/TUM-Live/blob/f80d12b754a30effed3f7bfc26533187351790d7/dao/migrator.go#L34 :)

joschahenningsen avatar Aug 11 '22 09:08 joschahenningsen

I think course.StreamEnabled becomes streamCtx.stream after sending the request to the worker.

https://github.com/joschahenningsen/TUM-Live/blob/fa9bfbf2c0a13dc9446a2325efb204d99cfea31a/worker/worker/request_handlers.go#L433

This should also be removed along with the logic for just recording without streaming.

Thanks!

the logic for just recording without streaming.

Thanks! How about the PublishStream attribute in the StreamRequest? I guess that should be deleted too.

MatthiasReumann avatar Aug 16 '22 13:08 MatthiasReumann

How about the PublishStream attribute in the StreamRequest?

Yup that should be removable as well then.

Am Di., 16. Aug. 2022 um 15:35 Uhr schrieb matthias < @.***>:

I think course.StreamEnabled becomes streamCtx.stream after sending the request to the worker.

https://github.com/joschahenningsen/TUM-Live/blob/fa9bfbf2c0a13dc9446a2325efb204d99cfea31a/worker/worker/request_handlers.go#L433

This should also be removed along with the logic for just recording without streaming.

Thanks!

the logic for just recording without streaming.

Thanks! How about the PublishStream attribute in the StreamRequest? I guess that should be deleted too.

— Reply to this email directly, view it on GitHub https://github.com/joschahenningsen/TUM-Live/pull/636#issuecomment-1216648389, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKV24QGBA6CPV3WX3UJ3GZLVZOKLDANCNFSM56HGNXTQ . You are receiving this because you commented.Message ID: @.***>

joschahenningsen avatar Aug 17 '22 10:08 joschahenningsen