Campus-Android
Campus-Android copied to clipboard
TUM-Dev
Bugfix/grades bar chart
This PR resolves #1505 for the grade diagram styling.
Now, the y-axis is removed if weights are used in the diagram. Additionally, the x-axis now shows the grades instead of "some" numbers and there is a small description for exams whch are marked as passed.
Chart diagram with weights:
Chart diagram without weights:
Since most phone screens are to small to display the values on top of the individual bars, I have replace them with horizontal lines to the y-axis. Additionally, the button to toggle between the diagrams is not shown in the edit mode anymore.
Yes, I mean the bar-chart. The bar chart shows not only ectsgrade but also includes a weight (e.g. PGDP has 6 ects and a weight of 0.5). Therefore, the y axis wouldn't directly translate to credits, but more as a general relation between them. The version "without weights" only counts exams with this grade, the version with weights computes weightects*grade.
I am wondering what benefit this visualization this would now have for a user. He knows then that in relation his 1.0 grades might count less than some 2.0 grades right?
For me it's hard to interpret that without knowing what is shown in the diagram at all. So either we add some explanation why it's useful or we make it more simple (e.g., just showing the amount of grades per grade again). But maybe someone else has another opinion on that? @CommanderStorm
Yes, it would only show the relation you described, without any real correlation. One idea that came to my mind would be to show percentages on the y axis in this case to visualize the proportion of one grade (with weighting) from the total set of grades and weightings. Then we would have a meaningful(lish) label for the diagram.
But maybe someone else has another opinion on that? @CommanderStorm
I will review this once my exams are done next week.
The crash was connected to inconsistent database version from switching between this branch and the chat removal. You have to manually uninstall the app. Before relaunching the version from the other branch. Depending on whether the chat removal PR gets merged soon, this can be merged afterwards or directly without the rebasing commits.
@tobiasjungmann sorry for the long delay on this one. Could you rebase onto main? 😅
Its finally rebased and manageable small again. Looking for your code reviews again!
