55 from ds

Open rogerkuou opened this issue 1 year ago • 2 comments

Fix #55.

[x] Add from_zarr function
[x] Add test files and unit tests
[x] Replace lint unit test with precommit hooks
[x] Remove example dir from ruff check

Oct 01 '24 14:10 rogerkuou

Hi @SarahAlidoost, when you have time, can you review this PR? The details should be in the issue description.

While creating this PR, the ruff linting is failling on the notebooks. These notebooks exists mainly for archiving purposes. In the future they will all be moved to PyDePSI workflow. Therefore I turned off ruff linting on them. I also replaced the unit test for linting with a pre-commit hook.

Oct 01 '24 14:10 rogerkuou

Thanks @SarahAlidoost! I adpted your suggestions and re-write from_zarr to from_ds. Now the reading function operates on a DS read by open_zarr. Can you give it another look?

Oct 11 '24 09:10 rogerkuou