php-dependency-injection-benchmarks icon indicating copy to clipboard operation
php-dependency-injection-benchmarks copied to clipboard

Published 20 hours ago • verified publisher icon TRPB

Circular dependency in testclasses.php

Open mindplay-dk opened this issue 10 years ago • 3 comments

It looks like you have a circular dependency here, e.g. K depends on K.

Is that deliberate?

mindplay-dk avatar Aug 22 '15 12:08 mindplay-dk

@mindplay-dk I've also notice that when I was optimizing the tests #17 for the latest version of my DiC . but i didn't find any test actually using the K class...

maybe @TomBZombie could share some light on the matter?

njasm avatar Aug 22 '15 13:08 njasm

Yeah, looks like it's actually unused, I noticed that as well - probably just left there by accident.

mindplay-dk avatar Aug 22 '15 14:08 mindplay-dk

Indeed, I did have a benchmark which looked at containers handling circular dependencies, however as not all of them actually support it I had to remove it entirely. I'll remove the unused class.

TRPB avatar Aug 22 '15 16:08 TRPB