SemanticDiff
SemanticDiff copied to clipboard
Incorrect palette when using light theme
Describe the Bug Some text in the diff is very hard to read with a light theme.
To Reproduce Steps to reproduce the behavior:
- Set a light theme
- Open any diff
Expected Behavior The color palette should roughly match the one used by the built-in diff viewer, or at least it should be readable.
Actual Behavior Semanticdiff uses lighter colors for the text and thus they are very hard to read
Screenshots Semanticdiff viewer:
Built-in viewer:
With dark theme the issue doesn't happen: both viewers work fine.
SemanticDiff Version 0.10.0
Thanks for the bug report. I just tried to reproduce it using the default light themes in VS Code 1.98.1 but didn't encounter this issue. Can you provide more information about what theme(s) you are using and whether you have setup any Token Color Customizations settings?
I have tried using Light Modern (the default light theme), bt the issue remains. I have no token color customization settings configured. Any other ideas?
Update: I have no idea why, but for some reason now the light theme is working correctly, I didn't change anything in the configuration
I'm also seeing this exact behavior with 0.10.0 and VS Code 1.99.2. I'm using the Bearded Theme Light theme.
Edit:
I just noticed that I was getting similar behavior in the dark theme:
I switched my theme back to the light theme, and now the coloring is working fine there:
I think the difference is that the 1st time my VS Code instance launched in light mode, vs the 2nd time it launched in dark mode, but I'm not certain.