jsonify icon indicating copy to clipboard operation
jsonify copied to clipboard

consolodate with RcppSimdJson

Open dcooley opened this issue 5 years ago • 5 comments

Given RcppSimdJson:::..deserialize_json() can replicate the behaviour of jsonify::from_json(), should I include RcppSimdJson as a LinkingTo, and use it if the end-user's hardware is up to it?


A wider question for @eddelbuettel & @knapply :

Do you think it's worth consolodating these libraries into one R package, which will automatically call either the simdjson or rapidjson .h code depending on the user's hardware?

Then there will only be one package which does both the from_json() and to_json()

dcooley avatar Jun 18 '20 22:06 dcooley

Good questions. I don't know. Good thing is I think we're not in a rush.

eddelbuettel avatar Jun 18 '20 22:06 eddelbuettel

Can LinkingTos be optional like Suggests?

As things currently stand, that would eliminate jsonify as an option for Windows and those lacking C++17 compilers.

knapply avatar Jun 18 '20 23:06 knapply

Can LinkingTos be optional like Suggests?

No. Only Suggests: has optionality :-/

eddelbuettel avatar Jun 18 '20 23:06 eddelbuettel

It would be nice. I'm presently using both in a package I'm developing :)

JosiahParry avatar Jan 10 '23 16:01 JosiahParry

I actually implemented a 'conditional' LinkingTo: once in a package in configure logic. If the (otherwise) Suggests:-only package is present, add a -I.... to the preprocessor/compiler flags. Easy enough and reliable.

eddelbuettel avatar Jan 10 '23 16:01 eddelbuettel