AdalFlow
AdalFlow copied to clipboard
Improve AWS bedrock integration
What does this PR do?
- Fixed existing issues due to
aws_profile_nameandaws_region_name - Fixed issues in
list_models()and added support to pass arguments for specific model fetching - Fixed
convert_inputs_to_api_kwargs()to acceptmodelasmodelIdandmax_tokensasmaxTokensinternally - Add functionality to accept
inferenceConfigandadditionalModelRequestFields - Added
aws_bedrock.rstfile for documentation - Added
tutorials\bedrock_client_simple_qa.pyfor showing usage example - Now bedrock can be used as similar to other models
tutorials\generator_all_providers.py
Fixes #283
Before submitting
-
[x] Was this discussed/agreed via a GitHub issue? (not for typos and docs)
-
[x] Did you read the contributor guideline? yes
-
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
-
[x] Did you make sure to update the documentation with your changes? (if necessary) Yes
-
[x] Did you write any new necessary tests? (not for typos and docs) Yes i have added mock tests and
tutorials\bedrock_client_simple_qa.py -
[x] Did you verify new and existing tests pass locally with your changes? Yes
-
[x] Did you list all the breaking changes introduced by this pull request? There is no breaking changes
was literally about to make a PR to fix the list model method. Looks like you beat me to it.
@ajithvcoder Hi, are you able to adapt this to work with this new PR for streaming in bedrock and also have no merge conflicts ?
@fm1320 it has been nearly 1.5 months so there are merge conflicts and will check the integration with this https://github.com/SylphAI-Inc/AdalFlow/pull/314 . I fix everything and update this by Jan 23.
@ajithvcoder the tests i wrote in https://github.com/SylphAI-Inc/AdalFlow/pull/314 are an adaptation of yours. So it should just work with your code.
@fm1320 the merge conflicts are fixed and #314 is already working fine as @lloydhamilton told.
@fm1320 could you review and merge ? else merge conflicts may occur again
Hi I would be curious if this PR can be merged