AdalFlow icon indicating copy to clipboard operation
AdalFlow copied to clipboard

Add new colab notebook for AdalFlow data class implementation

Open ajithvcoder opened this issue 1 year ago • 1 comments

Added a new notebook for dataclass tutorial based on following issues

  • https://github.com/SylphAI-Inc/AdalFlow/issues/194
  • https://github.com/SylphAI-Inc/AdalFlow/issues/123

ajithvcoder avatar Oct 09 '24 18:10 ajithvcoder

@liyin2015 let me know if the notebook is fine

ajithvcoder avatar Oct 09 '24 19:10 ajithvcoder

@ajithvcoder This is great work to show more complicated dataclass structure. I have left comments and basically need to add "No optional" in the dataclass. And please adjust to this new info and rerun the test again. And then it should be good to go!

Also, please rebase to the main as the current base failed on tests

liyin2015 avatar Oct 19 '24 19:10 liyin2015

@liyin2015 @Sylph-AI i will do the required changes but it wont pass the ci/cd because there is no quotes here . i have addressed similar issues in this pr https://github.com/SylphAI-Inc/AdalFlow/pull/227 . root cause: 3455b0321730d252defb2bb350a0a9ce9c74fac6

ajithvcoder avatar Oct 20 '24 01:10 ajithvcoder

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@liyin2015 i have made the changes kindly review, its a single file which is not in Adalflow/main branch so i didnt rebase it. Also it has successfully passed the checks

ajithvcoder avatar Oct 26 '24 06:10 ajithvcoder

found a method for rebasing and i have rebased it also

ajithvcoder avatar Oct 26 '24 06:10 ajithvcoder