Symfony deprecations

[dannyvw]

trafficstars

~~Since symfony/dependency-injection 5.1: The signature of method "Symfony\Component\DependencyInjection\Alias::setDeprecated()" requires 3 arguments: "string $package, string $version, string $message", not defining them is deprecated.~~

->setDeprecated(true, 'The "%alias_id%" service alias is deprecated since Sylius 1.8, use the "pagerfanta.twig_extension" service ID instead.');

---

~~Since symfony/framework-bundle 5.3: The "session" service and "SessionInterface" alias are deprecated, use "$requestStack->getSession()" instead. It is being referenced by the "sylius.resource_controller.flash_helper" service.~~

---

~~Since symfony/framework-bundle 5.3: The "session" service and "SessionInterface" alias are deprecated, use "$requestStack->getSession()" instead. It is being referenced by the "sylius.storage.session" service.~~

---

User Deprecated: Since symfony/twig-bundle 5.2: Accessing the "twig" service directly from the container is deprecated, use dependency injection instead.

class: ResoureController, line 240

---

~~User Deprecated: Since symfony/http-kernel 5.1: Referencing controllers with a single colon is deprecated. Use "app.controller.item::updateAction" instead.~~

---

~~User Deprecated: Method "Symfony\Component\Form\DataTransformerInterface::transform()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Sylius\Bundle\ResourceBundle\Form\DataTransformer\ResourceToIdentifierTransformer" now to avoid errors or add an explicit @return annotation to suppress this message.~~

~~User Deprecated: Method "Symfony\Component\Form\DataTransformerInterface::reverseTransform()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Sylius\Bundle\ResourceBundle\Form\DataTransformer\ResourceToIdentifierTransformer" now to avoid errors or add an explicit @return annotation to suppress this message.~~

---

User Deprecated: Since symfony/http-foundation 5.1: Retrieving a non-string value from "Symfony\Component\HttpFoundation\InputBag::get()" is deprecated, and will throw a "Symfony\Component\HttpFoundation\Exception\BadRequestException" exception in Symfony 6.0, use "Symfony\Component\HttpFoundation\InputBag::all($key)" instead.

class: HttpFoundationRequestHandler, line 88

---

~~User Deprecated: Method "Symfony\Component\Config\Loader\LoaderInterface::getResolver()" might add "LoaderResolverInterface" as a native return type declaration in the future. Do the same in implementation "Sylius\Bundle\ResourceBundle\Routing\ResourceLoader" now to avoid errors or add an explicit @return annotation to suppress this message.~~

---

~~User Deprecated: Method "Symfony\Component\Form\RequestHandlerInterface::isFileUpload()" might add "bool" as a native return type declaration in the future. Do the same in implementation "Sylius\Bundle\ResourceBundle\Form\Extension\HttpFoundation\HttpFoundationRequestHandler" now to avoid errors or add an explicit @return annotation to suppress this message.~~

[ztellman]

I don't have a strong opinion on this. Back when I was first targeting Netty 4, I tried to enumerate packages Aleph depended on, couldn't get it to work in a reasonable amount of time, and so just targeted the uberjar. If someone were to make it work for me, I'd have no problem merging the PR, but I don't see this as an immediate issue that requires fixing.

[danielcompton]

I've made a PR for this, but I agree it's not an urgent issue. I've done some testing on an actual project and everything seems fine.