Appz icon indicating copy to clipboard operation
Appz copied to clipboard

Updating Streamline branch

Open Dreamersoul opened this issue 9 years ago • 7 comments

Dreamersoul avatar Sep 28 '16 23:09 Dreamersoul

Salaam,

Great job :) Just a small note, in app_template.swift I think it's important to add author, current date, and current year :

//
//  {{ app.name }}.swift
//  Appz
//
//  Created by {{ author.name }} on {{currentDate}}.
//  Copyright © {{currentYear}} kitz. All rights reserved.
//

Does anyone agree?

Maryom avatar Sep 29 '16 05:09 Maryom

The files don't really have an author, so it's better be kept as is. Sure, the current_year would be a nice thing.

Mazyod avatar Sep 29 '16 07:09 Mazyod

If you don't mind I have a question what about using Swift script as mentioned here

And as mentioned: "Even if this isn’t the exact solution for the exact problem that you’re trying to solve, the concepts that we will go over here will be applicable to other Swift scripts that you might want to write."

I think it will be easier in testing.

Maryom avatar Sep 29 '16 09:09 Maryom

@Maryom What is your question?

Mazyod avatar Sep 29 '16 09:09 Mazyod

@Maryom It is up to the contributor to decide which language he prefers. It almost makes no difference what language is used for the script, as long as it provides the functionality we require and is widely available on most machines.

Mazyod avatar Sep 29 '16 09:09 Mazyod

@Mazyod You are right but I liked their way that why I shared it here. Do you think their way will be easier in testing? I think so ..

Maryom avatar Sep 29 '16 09:09 Maryom

@Maryom Why do you think it's easier to test? I'm sure it's harder. Testing in python is so easy, you literally do it like this using py.test:

class AppzTests:
  def test_1_plus_1():
    assert 1 + 1 == 2

Mazyod avatar Sep 29 '16 09:09 Mazyod