Appz icon indicating copy to clipboard operation
Appz copied to clipboard

Consider simplifying ExternalApp structure

Open Mazyod opened this issue 9 years ago • 6 comments

Having added applications inherit ExternalApplication gives us a lot of flexibility, but I am starting to question the need for such a flexible design. Perhaps making it a simple struct instance would reduce all the boilerplate code written for the added apps... Need to investigate.

Mazyod avatar Jan 06 '16 19:01 Mazyod

This looks great, I have a question we used ExternalApplication instead of calling openURL because of this 👇🏼 https://twitter.com/nicklockwood/status/595347585747001344

Maryom avatar Jan 06 '16 20:01 Maryom

nah, this is just a refactor to organize the library API

Mazyod avatar Jan 06 '16 20:01 Mazyod

Salam,

I think this will help, do you agree?

screen shot 2016-07-07 at 11 23 47 am

Maryom avatar Jul 07 '16 08:07 Maryom

This is real nice, we'll need to support this when it comes out, yes.

Mazyod avatar Jul 12 '16 02:07 Mazyod

Salaam,

I need to know still we need to support iOS 9 ? because I think it's better to use iOS 10 new method: open func open(_ url: URL, options: [String : Any] = [:], completionHandler completion: (@escaping (Bool) -> Swift.Void)? = nil)

There is a solution if we need to support iOS 9 but I just need to know to save some lines of code.

Maryom avatar Sep 21 '16 06:09 Maryom

This is a different feature, so I created a new issue for that here: #82

Mazyod avatar Sep 21 '16 07:09 Mazyod