SurfaceS

Results 98 comments of SurfaceS
trafficstars

> Netty 3 MediaServer implementation seems to have an issue serving large chunked streams and becomes more and more unresponsive over some time (a few seconds !). It should be...

I'm not reviewed the core goal of the PR. Only the Java part and UMS integration.

Tell me if I'm wrong, but I checked the code and I think that the changes in `RequestV2` can be completely removed, as the server serve the media url to...

> @SurfaceS I'm unsure who made the change: it looks like `RequestV2` is serving only WebAudioStreams now. I think this was initially matching WebStream as this would also let playlists...

@ik666 I checked the `RequestV2` changes, and that break transcoding for `WebAudioStream` from shared content when renderer cannot handle stream. I made a PR on your git (https://github.com/ik666/UniversalMediaServer/pull/89) that should...

Sorry, merging this to [m3u_uri_handling](https://github.com/UniversalMediaServer/UniversalMediaServer/tree/m3u_uri_handling) has closed it. I corrected thing in this PR. https://github.com/ik666/UniversalMediaServer/pull/90/files

`STORE.get(filename).get()` = NPE

> One more thing, please. If you don't mind, it would be nice to work on the same branch. Otherwise, we probable will get merge conflicts and I am usually...

> If we do lock on our own, the optimization of the ConcurrentHashMap implementation will be thrown away and we could replace it with a HashMap again ... True, and...

On this file, `synchronized (STORE)` was used for 2 things. - Prevent concurrency access (as the `STORE` is an `HashMap`). - Prevent multiple time the same request (bad usage). bottleneck...