laravel-google-cloud-storage icon indicating copy to clipboard operation
laravel-google-cloud-storage copied to clipboard

Laravel 9.x Compatibility

Open laravel-shift opened this issue 3 years ago • 9 comments

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l9-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift avatar Feb 01 '22 18:02 laravel-shift

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-google-cloud-storage.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "superbalist/laravel-google-cloud-storage": "dev-l9-compatibility",
    }
}

Finally, run: composer update

laravel-shift avatar Feb 01 '22 18:02 laravel-shift

@laravel-shift The change on this PR is not enough to be compatible with Laravel 9. Because this project has a direct dependency to the league/flysystem-cached-adapter which has a dependency to "league/flysystem": "~1.0". But Laravel 9 requires v3 of league/flysystem. So, that's a conflict and should be resolved in some way.

me-shaon avatar Feb 11 '22 16:02 me-shaon

@me-shaon, it's not meant to be the entire upgrade. It's more about awareness and giving package authors a start.

jasonmccreary avatar Feb 11 '22 17:02 jasonmccreary

@jasonmccreary you did a great job with the 'Laravel shift'. 🥇 Thanks for that.

me-shaon avatar Feb 11 '22 17:02 me-shaon

Be aware that this implementation is poorly maintained, and not compatible with Laravel 9 without further work.

We decided to switch to https://github.com/spatie/laravel-google-cloud-storage

kohlerdominik avatar Mar 02 '22 10:03 kohlerdominik

@kohlerdominik yeah, we did the same.

me-shaon avatar Mar 02 '22 10:03 me-shaon

Hey, does anyone know when will this be published?

mgallegos avatar May 15 '22 21:05 mgallegos

@mgallegos you should switch to: https://github.com/spatie/laravel-google-cloud-storage as this repo is not being actively maintained.

me-shaon avatar May 16 '22 10:05 me-shaon

Got it, thanks @me-shaon

mgallegos avatar May 16 '22 15:05 mgallegos