Is there a reason to explicitly set the visibility if not passed?

[phroggyy]

In the following lines, we check if the visibility has been specified, and if it hasn't we default to private. https://github.com/Superbalist/flysystem-google-cloud-storage/blob/master/src/GoogleStorageAdapter.php#L143-L149

Is there any reason we need to default to anything at all? If we specify nothing, the default object ACL of the bucket should be applied (by default private, visible to owner). This seems like more desirable behaviour imo – if users specify a default object ACL on their buckets, I believe it's expected that it will apply to uploaded files.

If there is a good reason this is being done, let's keep it but make it clear in the documentation that we're applying private visibility by default.

[alexking]

Also note that setting ACLs isn't supported by the new Bucket Only Policy, and causes an error when trying to upload, which makes the driver incompatible with buckets using it.

[nicja]

Could you have a look at PR https://github.com/Superbalist/flysystem-google-cloud-storage/pull/57 and see whether it addresses the issue? If so we can clean it up and get it merged

[phroggyy]

That looks like it would do it indeed @nicja

[nicja]

Thanks, I'm working on getting that merged

[stepanselyuk]

Would that be merged anytime soon?

[nicja]

I'm waiting on @mgriego to update #57 so that the tests pass, alternatively if someone else could raise a similar PR that would also help

[kublermdk]

I've gone down the path of manually updating what I needed to get this done: https://www.kublermdk.com/2022/01/29/googlecloud-flysystem-tweaks-to-support-uniform-bucket-level-access/

I assume others of you are doing the same given this PR has been sitting around for years.