add ReservedConcurrentExecutions to CF templates

[raylu]

we found that running these three lambdas without concurrency management was causing us to hit CloudWatch API rate limits. the Concurrency parameters default to the ReservedConcurrentExecutions's default, so this should be no change unless you set the Concurrency parameter(s)

[himanshu219]

apologize for late response. Just to clearify in the docs If you haven’t set up any function-level concurrency limit, then the unreserved concurrency limit is the same as the account level concurrency limit. but you are saying that by default it's taking ReservedConcurrentExecution limit?

[raylu]

sorry, I realize now my desc is a bit confusing. ReservedConcurrentExecutions's default is -1, which means use unreserved (not-per-function) concurrency. I defaulted Concurrency to -1, so this should just be setting the value to the default

[himanshu219]

oh got it you are just parameterising the ReservedConcurrentExecutions parameter. @duchatran it's good idea to have this exposed during CF deployment but I guess we should have separate limit for each of the functions. What do you think? or should we just add a note in our docs and let the user do it themselves from lambda console based on their account concurrency limit.

[raylu]

the account-wide (unreserved) concurrency limit applies to all lambda functions running in that AWS account, so it's unlikely you'd want to control concurrency there (also you can't really lower it)

[raylu]

bump!

[raylu]

hi! do you need me to rebase to handle the conflicts?

[raylu]

looks like this is not getting merged. it would still be an improvement, but I'm cleaning up my /pulls view so I'm closing this

if anyone ever looks at this, feel free to re-open and merge