js-sumo-logger icon indicating copy to clipboard operation
js-sumo-logger copied to clipboard

Published 20 hours ago • verified publisher icon SumoLogic

Prevent throwing when batchSize and raw specified

Open srolel opened this issue 4 years ago • 3 comments

when both are specified, the JSON.parse call throws.

srolel avatar Feb 03 '21 08:02 srolel

Appreciate the PR @srolel can you rebase with master so we can run the latests tests on your PR. Then we can merge this in.

safaiyeh avatar Jun 11 '21 22:06 safaiyeh

Appreciate the PR @srolel can you rebase with master so we can run the latests tests on your PR. Then we can merge this in.

Done!

srolel avatar Aug 21 '21 23:08 srolel

Hi @srolel! I'm sorry for the delay, but I'm picking up the repository for maintenance after a period of hiatus.

Are you sure that the ternary operator isn't flipped, though? Your change means that we'd never use JSON.parse() on string, actually. As for the change, once we settle on the solution, I can merge and release it soon.

bpolanczyk avatar Jan 19 '22 12:01 bpolanczyk