UnitTesting icon indicating copy to clipboard operation
UnitTesting copied to clipboard

Published 20 hours ago • verified publisher icon SublimeText

WIP New command API

Open gerardroche opened this issue 7 years ago • 3 comments

This is a WIP to gather some feedback, it's not yet ready to be merged.

The main idea here is to create an API compatible with the spec outlined in https://github.com/gerardroche/sublime-test.

The PR currently includes the new functionality:

  • Improved support for https://github.com/gerardroche/sublime-test
  • Run tests for current file
  • Switch module/test-module command
  • Support for color in test results including diffs
  • Done messages are now only printed on CI test runs

gerardroche avatar Jan 28 '18 09:01 gerardroche

Awesome, looking forward to it.

randy3k avatar Jan 28 '18 12:01 randy3k

Is it ready to review?

randy3k avatar Feb 10 '18 01:02 randy3k

I haven't had time to do anything more with it. It works though, and it's pretty much backwards compatible, so merging it shouldn't really break anything.

Some of the new commands haven't been implemented yet and I don't know when I'll get the time to do those, but they can be added later.

The new commands that have been implemented only really add new functionality without breaking existing functionality.

The old commands haven't been removed, some of them now just proxy to the new command and print a deprecation message.

The internals of the code is maybe a little messy and could maybe do with some cleanup, but that won't affect end users. So I think it can probably merged. Like I said, I've been using it without any problems at all.

gerardroche avatar Feb 12 '18 04:02 gerardroche