UnitTesting icon indicating copy to clipboard operation
UnitTesting copied to clipboard

WIP: Asyncio in run tests script

Open rwols opened this issue 5 years ago • 4 comments

Only tested for Linux and tested locally. So my expectation is that the CI will fail. This branch should evolve more.

I have also replaced the polling behavior to check whether the UnitTesting plugin is loaded by a UnitTestingSchedulerPingCommand class. The run_tests.py script calls this command via subl --command unit_testing_scheduler_ping. Once UnitTesting is loaded, that command will write to a flie. In run_tests.py we check whether that file exists. If it exists, then we know that UnitTesting is loaded.

rwols avatar Mar 22 '20 18:03 rwols

The py versions are too old in the docker images :)

rwols avatar Mar 22 '20 19:03 rwols

Thank you for working on it. I wanted to rewrite the script for a long time. We use a different file run_tests.ps1 for windows. That one needs to be patched too.

randy3k avatar Mar 23 '20 05:03 randy3k

How attached are you to the run_tests.ps1 script? Would it be possible to run run_tests.py in a windows environment as well? Because we're running a TCP server in run_tests.py and I don't know how to achieve that in Powershell. Other than calling the run_tests.py script from run_tests.ps1.

rwols avatar Mar 30 '20 21:03 rwols

Actually, the windows support was mainly contributed by @guillermooo. I personally do not have any preference. Actually, it may be easier for a maintenance point of view if any platform uses the same code.

It may be a good time to introduce some breakage when ST4 is out.

randy3k avatar Apr 04 '20 18:04 randy3k