Colorize many things

[koumaza]

trafficstars

Probably, Squash and Commit required.

UserCss: https://github.com/koumaza/GitHub-Dark/blob/koumaza/suggestion/github-dark.user.css?raw=true

Screenshots

• Close button
  • 
• Dropdown Caret
  • 
• Kebab Icon
  • 
• Markdown Anchor
  • When :active
  • 
• Organizations Border
  • 
• Acv Underline
  • When :hover
  • 
• "Remove Public Email" Colorize in Settings/Profile
  • 

[silverwind]

Hmm not sure on this one. We generally follow the rule that if something is not colored in the original themes, we don't add color. Of course there are exceptions like the navbar hover, but generally I think we should not stray too far from the original style.

Another issue is all these "manual" rules will sooner or later become outdated because GitHub often rapidly changes things, so they will eventually become a maintenance burden.

[koumaza]

Hi @silverwind I understood. But, Kebab Icon and Markdown Anchor are colorize comes from the original style. I'll make change just for them.

Another issue is all these "manual" rules will sooner or later become outdated because GitHub often rapidly changes things, so they will eventually become a maintenance burden

This is the fate of UserCss.

[the-j0k3r]

Again, replace CSS vars colors instead of adding more selectors, what youre doing is only OK if for instance GH isnt using css vars in that particular area.

This style already has many many opinionated tweaks to colors in these octicon-x areas so these fit right in, however adding more selectors is not the way, replacing CSS vars colors is the only way to get sane styles.

[koumaza]

OK, I'll add to vars.css