GitHub-Dark icon indicating copy to clipboard operation
GitHub-Dark copied to clipboard

GitHub Sponsor Card page is not in dark.

Open OrigamiDream opened this issue 5 years ago • 4 comments
trafficstars

  • Browser: Safari 14
  • Operating System: macOS Big Sur
  • Link to page with the issue: https://macosicons.com (Embedded in this page), https://github.com/sponsors/elrumo/card
  • Screenshot: 스크린샷 2020-11-15 오전 12 47 30

The page can be attached in other pages.

OrigamiDream avatar Nov 14 '20 15:11 OrigamiDream

How are they embedded? iframe?

silverwind avatar Nov 14 '20 22:11 silverwind

They provide a button and a card that you can embed.

Sponsor button

<iframe src="https://github.com/sponsors/xt0rted/button" title="Sponsor xt0rted" height="35" width="116" style="border: 0;"></iframe>

Sponsor card

<iframe src="https://github.com/sponsors/xt0rted/card" title="Sponsor xt0rted" height="225" width="600" style="border: 0;"></iframe>

xt0rted avatar Nov 14 '20 23:11 xt0rted

I see. What's also odd is that black bar on bottom.

I wonder if it's somehow possible to define styles that only apply when a page is iframed. I guess not and we need to match on the URL with a regex rule.

silverwind avatar Nov 15 '20 08:11 silverwind

Most of user-css extensions (e.g. Cascadea, Stylus) applies the styles recursively. Therefore you don't need to detect if the page is I-framed.

OrigamiDream avatar Nov 15 '20 08:11 OrigamiDream