GitHub-Dark icon indicating copy to clipboard operation
GitHub-Dark copied to clipboard

Two close buttons displayed on edit history window

Open Geeyun-JY3 opened this issue 5 years ago • 5 comments
trafficstars

  • Browser: Cent Browser 4.2.10.171 (64-bit) (Chromium 80.0.3987.163), Chrome 84.0.4147.89 (Official Build) (64-bit)
  • Operating System: Windows 10 1909
  • Link to page with the issue: any page
  • Screenshot: testimage

Geeyun-JY3 avatar Aug 02 '20 03:08 Geeyun-JY3

The base html has 2 buttons which might be a bug on GitHub's end. This rule changes the box header size which causes the second one to become visible:

.Box-header, .Box-row, .Box-body {
  padding: 8px 12px;
}

@silverwind 9ecd373f913b8e8e18e0e151b5c3b594bedca5c3 caused this issue.

xt0rted avatar Aug 02 '20 04:08 xt0rted

Any link to a page containing this?

silverwind avatar Aug 02 '20 08:08 silverwind

@silverwind I have edited this issue.

Geeyun-JY3 avatar Aug 02 '20 09:08 Geeyun-JY3

Ah I see, should have mentioned issue. I was thinking wiki.

silverwind avatar Aug 02 '20 09:08 silverwind

This is a hard one. If we hide one button, we risk having none appear after this issue is fixed. Certainly a GitHub bug but only visible with our padding tweak, otherwise the two buttons overlap exactly.

silverwind avatar Aug 02 '20 09:08 silverwind