antlr-kotlin icon indicating copy to clipboard operation
antlr-kotlin copied to clipboard

Open up methods and classes

Open piacenti opened this issue 5 years ago • 1 comments

ANTLR was designed with extensibility through subclassing in mind. There are currently some limitations where we can't subclass or override methods. One such example is if you want to disable recovery on a Lexer (currently the recover method is not open). Might be worth using the kotlin-allopen plugin to help with some of that.

piacenti avatar Jul 15 '20 04:07 piacenti

Thank you for opening the issue. This code has been created as a direct translation from the Java codebase, so we inherited the same approach here. I agree it could make sense to increase openness and I would be happy to consider PRs for that

ftomassetti avatar Jul 17 '20 06:07 ftomassetti

Most classes and methods/properties have been opened.
I think this can be closed in favor of more specific issues.

lppedd avatar Jan 19 '24 12:01 lppedd

Agreed

ftomassetti avatar Jan 19 '24 15:01 ftomassetti