stride icon indicating copy to clipboard operation
stride copied to clipboard

Published 20 hours ago • verified publisher icon Stride-Labs

Unnecessary ICA transactions in every epoch.

Open jongseokleedev opened this issue 2 years ago • 3 comments

Background

k.SetWithdrawalAddress(ctx) in x/stakeibc/keeper/hooks.go is called every STRIDE EPOCH I think it is unnecessary and it could cause tx fee leaks.

Suggested Design

  • SetWithdrawalAddress(ctx) function needs to be executed only once when the host zone is registered at first. please let me know if there is any other reason why it should be called every epoch.

jongseokleedev avatar Feb 14 '23 06:02 jongseokleedev

Hey @jongseokleedev, you’re absolutely right, this has been in our backlog for a bit. Can you say more about the fee leakage? Was that more from the perspective of the relayer?

sampocs avatar Feb 14 '23 13:02 sampocs

Hi @sampocs , I'm not sure if it was the proper word to describe this issue as leakage, I just wanted to say that it could cause more tx fees from the perspective of the relayer due to unnecessary Txs. is this code written as a workaround for a specific issue? I was wondering background history of this code.

jongseokleedev avatar Feb 14 '23 14:02 jongseokleedev

It's just legacy code that's been in there for awhile. Should be resolved in either of the next two upgrades

sampocs avatar Feb 15 '23 18:02 sampocs