jsonschema-rs icon indicating copy to clipboard operation
jsonschema-rs copied to clipboard

Replace `structopt` with `clap`

Open Expyron opened this issue 3 years ago • 3 comments

Expyron avatar Sep 15 '22 08:09 Expyron

What is the reason for this change?

Stranger6667 avatar Sep 15 '22 08:09 Stranger6667

Structopt is not maintained anymore: https://github.com/TeXitoi/structopt/issues/525 Its author recommends moving to clap v3.

Expyron avatar Sep 15 '22 08:09 Expyron

Codecov Report

Merging #384 (84ed9c9) into master (5da8685) will increase coverage by 0.01%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   82.50%   82.52%   +0.01%     
==========================================
  Files          57       57              
  Lines        5562     5579      +17     
==========================================
+ Hits         4589     4604      +15     
- Misses        973      975       +2     
Impacted Files Coverage Δ
jsonschema/src/main.rs 0.00% <ø> (ø)
jsonschema/src/keywords/format.rs 88.63% <78.57%> (-0.61%) :arrow_down:
jsonschema/src/compilation/options.rs 87.34% <100.00%> (+0.21%) :arrow_up:
jsonschema/src/error.rs 64.14% <0.00%> (ø)
jsonschema/src/lib.rs 82.43% <0.00%> (+1.35%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 15 '22 08:09 codecov[bot]

As is I think this also is triggering GitHub security warnings for users of jsonschema-rs -- e.g. on bowtie, due to the transitive dependency on ansi_term, I see:

Screen Shot 2022-09-17 at 14 47 01

EDIT: It seems the advisory was now retracted, so the above isn't true anymore.

Julian avatar Sep 17 '22 11:09 Julian

Sorry for the delay! Merged :) I'll make a new release soon

Stranger6667 avatar Oct 18 '22 21:10 Stranger6667