add segmented control dependency from react-native-community

Open drewvolz opened this issue 3 years ago • 6 comments

Fixes a warning in the app regarding SegmentedControlIOS

SegmentedControlIOS has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from @react-native-community/segmented-control instead of react-native.

Nov 12 '22 00:11 drewvolz

Do we know why build for iOS and build for android jobs were skipped?

Nov 12 '22 00:11 drewvolz

Looks like they depend on tsc passing…

Nov 12 '22 14:11 hawkrives

@hawkrives @rye until we fix all of the tsc errors, should we adjust the pipeline to not skip the native builds?

Nov 19 '22 03:11 drewvolz

Yeah

Nov 20 '22 03:11 hawkrives

Codecov Report

Merging #6572 (14f4d86) into drew/rn-71 (1526aab) will not change coverage. The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           drew/rn-71   #6572   +/-   ##
==========================================
  Coverage        8.09%   8.09%           
==========================================
  Files             289     289           
  Lines            5412    5412           
  Branches         1451    1451           
==========================================
  Hits              438     438           
  Misses           4954    4954           
  Partials           20      20

Nov 20 '22 20:11 codecov[bot]

Error when running detox

import { device } from 'detox';

SyntaxError: Cannot use import statement outside a module

I think we need to configure a transform exception for detox (or something else) similarly to how we fixed this type of module error before for @frogpond and @react-native scoped packages e.g. https://github.com/StoDevX/AAO-React-Native/pull/6152/commits/1ff97cf3e106e98656ec88a2a071487f9b877e32

Nov 20 '22 20:11 drewvolz