AAO-React-Native icon indicating copy to clipboard operation
AAO-React-Native copied to clipboard
verified publisher icon StoDevX

🖨 stoPrint tweaks

Open drewvolz opened this issue 6 years ago • 2 comments

Potentially fixes #3986

The diff is a little misleading. I recommend expanding the collapsed lines to gain full context.

Two things:

  1. I'm noticing an error view that reports that login was incorrect (alert) but the stoprint error view reports that the print server was having issues. I've flipped these two conditionals. Not sure if this works in the other case now. Can someone with credentials check, please?

  2. The StoPrintErrorView and StoPrintNoticeView each are wrapped by the Timer component with intervals. I've opted to remove the timer/interval from the case where login fails. This is where that infinite alert view is happening, I think. Someone with credentials will have to test this, too, please.

I'm not 100% confident on these changes so please help test these. Thanks!

drewvolz avatar Nov 02 '19 00:11 drewvolz

Codecov Report

Merging #4157 (c397abb) into master (196816b) will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

codecov[bot] avatar Nov 02 '19 00:11 codecov[bot]

Unsure what the right approach here should be. Closing this PR as we have the tracking issue.

drewvolz avatar Apr 14 '22 22:04 drewvolz

@drewvolz should we close this MR? Or is it still valuable?

hawkrives avatar Jan 20 '23 21:01 hawkrives

We can close if we've resolved infinite error alerts for incorrect credentials.

drewvolz avatar Jan 20 '23 22:01 drewvolz

Enough of the implementation has changed that I feel confident in saying that we will no longer have infinite alerts.

hawkrives avatar Jan 21 '23 04:01 hawkrives

Alright! Closing this.

drewvolz avatar Jan 21 '23 04:01 drewvolz