Stephan Hasler comments

Results 7 comments of


                                            Stephan Hasler

rospy get_param('') behaves differently after rospy.loginfo()

Same issue here. I'm using noetic.

Added the ip and port as launch arguments in the ros2 launch file

BTW: The naming of the parameters is inconsistent with the ROS1 version. There the parameters are tcp_ip and tcp_port. Also the internal variables are called likewise. See #123 why the...

SimpleActionState not reusable after preemption if goal not preempted

Actually it can be reduced to the simple logic: After a state has been executed, in each case its preempt_requested flag should be set to false. Either the state does...

SimpleActionState not reusable after preemption if goal not preempted

I guess your proposed solution will solve the problem for most use cases. But still we should try to find an even more general solution that is not just optimal...

SimpleActionState not reusable after preemption if goal not preempted

Yes, you are right. All ROS states have similar flaws regarding preemption. You could of course check the preempt_requested in the response_callback. Or you could add more service_preempt()'s at several...

Deal with prior preemption and runaway child states.

Preempting a concurrence before executing child states might help to realize a specific application behavior, but it should be the users choice if he likes to have this and not...

``duplicate-code`` are always counted on the last module checked

Same problem here. Would be nice to have this fixed.