Steeltoe icon indicating copy to clipboard operation
Steeltoe copied to clipboard

Review skipped tests

Open bart-vmware opened this issue 3 years ago • 5 comments

At this moment (August 2022), we have 49 unconditionally skipped tests, and 22 tests that are excluded on Linux and/or MacOS. Some were suppressed due to bugs that have been fixed by now. We should re-check all of them and per case, either:

  • Add an explanation comment in the code why the test is (conditionally) skipped
  • Re-activate the skipped test

bart-vmware avatar Aug 17 '22 16:08 bart-vmware

I know there's still one test related to #985 that needs to be addressed, but are there any others remaining that we plan to address? @dtillman

TimHess avatar Oct 19 '22 20:10 TimHess

If I remember correctly, there are still a few skipped tests that depend on fixes from Microsoft that might appear in 7.0.

dtillman avatar Oct 19 '22 20:10 dtillman

Query: https://github.com/search?q=repo%3ASteeltoeOSS%2FSteeltoe+%22Skip+%3D+%22&type=code

bart-vmware avatar Jul 18 '23 15:07 bart-vmware

I think we took care of all the tests we need to for now

TimHess avatar Dec 06 '23 00:12 TimHess

This was closed, while not everything was addressed. How about these?

  • https://github.com/SteeltoeOSS/Steeltoe/blob/50ede426e23d3d7748f40c5793a1b0feedf8e092/src/Configuration/test/ConfigServer.Integration.Test/ConfigServerConfigurationExtensionsIntegrationTest.cs#L190
  • https://github.com/SteeltoeOSS/Steeltoe/blob/50ede426e23d3d7748f40c5793a1b0feedf8e092/src/Configuration/test/ConfigServer.Integration.Test/ConfigServerConfigurationExtensionsIntegrationTest.cs#L272

bart-vmware avatar Dec 06 '23 13:12 bart-vmware