Steeltoe icon indicating copy to clipboard operation
Steeltoe copied to clipboard

Mappings endpoint should return parameters for url

Open thompson-tomo opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe.

The mappings endpoint can make available a list of parameters required however the Steeltoe Implementation doesn't attempt to process them.

Describe the solution you'd like

When the mappings actuator/endpoint is called, the user should be informed if the url supports parameters required for URL.

Additional context

Implementation is clear that it is not implemented yet: https://github.com/SteeltoeOSS/Steeltoe/blob/15a935310989d02eba940116cc5f911a3bd96f78/src/Management/src/Endpoint/RouteMappings/RouteMappingDescription.cs#L93 Parameters can be obtained from: Microsoft.AspNetCore.Mvc.Controllers.ControllerActionDescriptor.Parameters

thompson-tomo avatar May 26 '24 08:05 thompson-tomo

This was a deliberate choice in https://github.com/SteeltoeOSS/Steeltoe/pull/1153. I don't exactly remember why this information was hard to obtain, but I suspect we could only support the simple cases (attribute-based routing, no constraints, no patterns, method parameter name equals route parameter name, etc) and be wrong otherwise.

bart-vmware avatar May 27 '24 04:05 bart-vmware