Steeltoe icon indicating copy to clipboard operation
Steeltoe copied to clipboard

Reliability improvements for service discovery

Open bart-vmware opened this issue 1 year ago • 3 comments

Description

  • Fixed: ObjectDisposedException within Consul when using discovery-first config server (service container is disposed too soon)
  • Enforce fetching registry in ConfigServer discovery-first with Eureka
  • Allow non-conflicting Eureka instance configuration changes, since InstanceId is already made unique when dynamic ports assignment is used (this removes the requirement to explicitly configure the Instance ID)
  • Skip over throwing IDiscoveryClients in load balancers (renamed CachingServiceInstancesResolver to ServiceInstancesResolver, changed static to instance and made public)
  • Fixed: Do not log exception at shutdown when Eureka is disabled
  • Fixed: do not report health when Consul is disabled

Quality checklist

  • [x] Your code complies with our Coding Style.
  • [x] You've updated unit and/or integration tests for your change, where applicable.
  • [ ] You've updated documentation for your change, where applicable. If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • [ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • [ ] You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

bart-vmware avatar May 07 '24 12:05 bart-vmware

/azp run Steeltoe.All

bart-vmware avatar May 07 '24 12:05 bart-vmware

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 13 '24 11:05 azure-pipelines[bot]