Steeltoe icon indicating copy to clipboard operation
Steeltoe copied to clipboard

Add support for Application Configuration Service

Open TimHess opened this issue 2 years ago • 2 comments

Description

Adds a post-processor that remaps all non-system keys (eg: type and provider) to the root of the IConfiguration

Fixes #1195

Quality checklist

  • [ ] Your code complies with our Coding Style.
  • [ ] You've updated unit and/or integration tests for your change, where applicable.
  • [ ] You've updated documentation for your change, where applicable. If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • [ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • [ ] You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

TimHess avatar Oct 04 '23 18:10 TimHess

This should be ready after we make sure hierarchy is support in config keys via double-underscore, the same as documented in Microsoft's key-per-file provider

TimHess avatar Nov 20 '23 23:11 TimHess

This work is being deprioritized right now, if it would mean something to you (the reader of this message) please let us know and we'll finish it up and ship it

TimHess avatar Dec 08 '23 19:12 TimHess

This PR has test failures in Connectors, which doesn't show up in the checks because Steeltoe.All has not run. This proves having only component builds is fundamentally unreliable, as the trigger conditions are unaware of project dependencies. So I propose we always run the full build on PRs, not as a manual step.

bart-vmware avatar Mar 15 '24 09:03 bart-vmware

/azp run Steeltoe.All

TimHess avatar Mar 15 '24 12:03 TimHess

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 15 '24 12:03 azure-pipelines[bot]

This PR has test failures in Connectors, which doesn't show up in the checks because Steeltoe.All has not run. This proves having only component builds is fundamentally unreliable, as the trigger conditions are unaware of project dependencies. So I propose we always run the full build on PRs, not as a manual step.

Or we could add the dependencies to the component builds... but Steeltoe.All does run a lot faster than it did a year or two ago, so I'm open to trying out that change

TimHess avatar Mar 15 '24 12:03 TimHess

Or we could add the dependencies to the component builds... but Steeltoe.All does run a lot faster than it did a year or two ago, so I'm open to trying out that change

That'll break sooner than later. I prefer to add Steeltoe.All, so we'll have some quick feedback from the component builds, while at the same time validating the full build.

bart-vmware avatar Mar 15 '24 14:03 bart-vmware

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 27 '24 19:03 azure-pipelines[bot]

/azp run Steeltoe.All

bart-vmware avatar Mar 28 '24 14:03 bart-vmware

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 28 '24 14:03 azure-pipelines[bot]