SteamKit icon indicating copy to clipboard operation
SteamKit copied to clipboard

Depotmanifest.Serialize() should be made public.

Open nightshadow92 opened this issue 1 year ago • 2 comments

What problem is this feature trying to solve?

Currently, the only way to save DepotManifest is using SaveToFile(), making Serialize() public would allow alternatives.

How would you like it to be solved?

Make the Serialize() function in DepotManifest public.

Have you considered any alternative solutions

No.

Additional Information

No response

nightshadow92 avatar Apr 22 '24 23:04 nightshadow92

Serialize() should accept a Stream (which removes the internal MemoryStream), and then SaveToFile can pass the file stream directly in, and then an overload can be added like SaveToStream (for consistency) which just calls Serialize.

PRs welcome.

xPaw avatar Apr 23 '24 10:04 xPaw

I've implemented a potential solution for this. Please see PR #1337 for a minimalistic approach that addresses the issue.

skylayer avatar Apr 23 '24 18:04 skylayer