ob-table-enhancer
ob-table-enhancer copied to clipboard
Stardusten
floating pane doesn't show up
version 1.4.1 the floating pane doesn't show up when right click
Same here, incredibly useful add-in otherwise. I think it went with Obsidian v 1.4.2
I am using Table Enhancer v0.5.10 & Obsidian v1.4.5 with the same problem
what's going on? the problem is I cannot find
A: Make sure "Settings - Appearance - Native menus" is DISABLED!
@avraam-inside test with https://github.com/Stardusten/ob-table-enhancer/pull/98 @Stardusten please review https://github.com/Stardusten/ob-table-enhancer/pull/98
@zhaihao
请问可以提供编译后的js代码段吗？
这段js代码无效
this.registerEvent(this.app.workspace.on("layout-change", function () {
const view = this.app.workspace.getActiveViewOfType(MarkdownView).contentEl;
view.querySelectorAll("div.cm-embed-block.cm-table-widget").forEach(function (el) {
el.attributes.getNamedItem("contenteditable").value = "true";
});
}));
I tried both code block options - it doesn't work(
@zhaihao - I stuck your piece of code into compiled "main.js" file of the plugin - but the plugin simply does not start because of the line "view: HTMLElement". Without it - plugin runs, but doesn't work.
@Yzzzzzzzzzzzz Your option runs the plugin, but contenteditable is still "false"
It is not possible to get into this event through debugger - do you have any ideas why it does not work when the plugin is launched?
I tried both code block options - it doesn't work(
@zhaihao - I stuck your piece of code into compiled "main.js" file of the plugin - but the plugin simply does not start because of the line "view: HTMLElement". Without it - plugin runs, but doesn't work.
@Yzzzzzzzzzzzz Your option runs the plugin, but contenteditable is still "false"
ignore ts compile error // @ts-ignore
please try to replace main.js and reload obsidian
@Yzzzzzzzzzzzz @avraam-inside
I could help out with running tests on the new code to see if it works or not. let me know.
Fixed in the latest release https://github.com/Stardusten/ob-table-enhancer/releases/tag/0.5.11. Big thanks to @zhaihao
@Stardusten
Yes, but what have you released?) We have been in correspondence here above - no solution has been found, and the proposed ones do not work. I downloaded the release - still hanging contenteditable = false
☝️ Can confirm this on my side. Having the same problem.
@Stardusten
Yes, but what have you released?) We have been in correspondence here above - no solution has been found, and the proposed ones do not work. I downloaded the release - still hanging contenteditable = false
My bad. My current workaround doesn't work all the time. I still need some time to figure out how to fix it.
@Stardusten No worries. Take your time. The problem is a challenge to overcome. Again, let me know when your fix is ready for testing so I can test it on my side.
☝️ Can confirm this on my side. Having the same problem.
@Stardusten Yes, but what have you released?) We have been in correspondence here above - no solution has been found, and the proposed ones do not work. I downloaded the release - still hanging contenteditable = false
My bad. My current workaround doesn't work all the time. I still need some time to figure out how to fix it.
@Stardusten "layout-change" event only works when we change from reading view to living view. So, if we click the "edit this block" button, the DOM will be re-rendered, and contenteditable will be set to false again. I can't find any API for this event. The "editor-change" event maybe work well but has poor performance.
☝️ Can confirm this on my side. Having the same problem.
@Stardusten Yes, but what have you released?) We have been in correspondence here above - no solution has been found, and the proposed ones do not work. I downloaded the release - still hanging contenteditable = false
My bad. My current workaround doesn't work all the time. I still need some time to figure out how to fix it.
@Stardusten "layout-change" event only works when we change from reading view to living view. So, if we click the "edit this block" button, the DOM will be re-rendered, and contenteditable will be set to false again. I can't find any API for this event. The "editor-change" event maybe work well but has poor performance.
I think pop out a menu when click a table cell would be better. But that may take some times.