mediawiki-extensions-EmbedVideo icon indicating copy to clipboard operation
mediawiki-extensions-EmbedVideo copied to clipboard

Published 20 hours ago • verified publisher icon StarCitizenWiki

Fixed issue #115 as well as another issue that would break the Description2 extension

Open bertrandgorge opened this issue 7 months ago • 2 comments

Hello @octfx, here is a PR that fixes the compatibility issue with mediawiki/iframe-tag as well as another issue I found, that would break the Description2 extension (the html comments that were surrounding the carriage returns). Removing the comments fixes the issue...

bertrandgorge avatar Apr 18 '25 11:04 bertrandgorge

Thanks for the PR! Would you mind reverting the version changes so I can merge this?

octfx avatar May 05 '25 07:05 octfx

Would you mind reverting the version changes so I can merge this?

Sure...! Don't know how I came up into bumping it...!

bertrandgorge avatar May 09 '25 08:05 bertrandgorge

Now to finally finally get this merged, there is one failing test: https://github.com/StarCitizenWiki/mediawiki-extensions-EmbedVideo/blob/5c0f542d29c59fe57b020868093d38e99c3bc95b/tests/phpunit/EmbedVideoTest.php#L139

Could you add the newly introduced https: prefix there?

octfx avatar May 27 '25 06:05 octfx