StanAngeloff
Enhancements for php5-fpm, mysql, etc
Looks awesome, I may need to make some tweaks and name changes. Would push a commit likely tomorrow or early next week and would update here with reason behind changes.
Sounds great On Sep 8, 2012 2:02 PM, "Stan Angeloff" [email protected] wrote:
Looks awesome, I may need to make some tweaks and name changes. Would push a commit likely tomorrow or early next week and would update here with reason behind changes.
— Reply to this email directly or view it on GitHubhttps://github.com/StanAngeloff/vagrant-shell-scripts/pull/3#issuecomment-8393562.
I've started looking at the pull and I've stopped at the MySQL and PHP5 functions as I need to learn more on those. I think mysqladmin is more appropriate for issuing commands like creating new databases and users so would be looking at that. As for PHP5-FPM, using sockets for listening is only in 12.04 while the previous LTS uses ports so there needs to be more code to handle both cases.
I'm about to add some comments against your diff for [my] future reference. Leaving pull open until I find more time to roll up the rest of the code.