st2 icon indicating copy to clipboard operation
st2 copied to clipboard

fixes issues #6021 and # 5327

Open fdrab opened this issue 1 year ago • 3 comments

Added max_page_size to api_opts and added limit & offset to action_service and sensor_service list_values() method

fdrab avatar Jul 05 '24 16:07 fdrab

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 05 '24 17:07 CLAassistant

A lot of failed tests here.

ajjonen avatar Jul 09 '24 16:07 ajjonen

yes, will look at what's wrong soon

fdrab avatar Jul 10 '24 15:07 fdrab

the failing check is due to st2-ldap-auth failing sha checksum after download. not for me to fix.

fdrab avatar Sep 06 '24 16:09 fdrab

regarding CLA I was also the person that committed the initial commits. how do I fix that?

fdrab avatar Sep 06 '24 16:09 fdrab

@fdrab You'll need to amend the commits with the correct email address in the branch and force push to update. Information on how to amend commits here (interactive would probably be the easiest approach) here https://www.git-tower.com/learn/git/faq/change-author-name-email/

nzlosh avatar Sep 08 '24 13:09 nzlosh

I've made a mess of things by not force pushing, but hopefully this is OK now. let me know if I need to do anything more

fdrab avatar Sep 09 '24 08:09 fdrab

I am for just merging this. The requirements changes are clouding it a bit and can be fixed after.

ajjonen avatar Sep 09 '24 12:09 ajjonen

@ajjonen are you able to approve with @guzzijones account as that is the one official recognised as a StackStorm maintainer.

nzlosh avatar Sep 10 '24 06:09 nzlosh