st2 icon indicating copy to clipboard operation
st2 copied to clipboard

limit memory and output

Open Moradf90 opened this issue 4 years ago • 9 comments

we use stackstorm as a base platform to execute plugin actions on our product. the plugins (packs on st2) will be developed by anyone who will integrate with our product. then we need to limit the execution to maximum memory size and maximum output result. add two new configurations underperformance:

  • action_max_memory_mb
  • action_max_output_size_mb by default, they set to zero, which means unlimited.

Moradf90 avatar Aug 05 '21 13:08 Moradf90

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: cognifloyd
:x: Morad Faris


Morad Faris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 05 '21 13:08 CLAassistant

Thanks for the contribution.

The change overall seems reasonable (I will add in-line code comments later), but can you please provide some context and background on this change?

Kami avatar Aug 17 '21 17:08 Kami

@Moradf90 I just merged in Master.

Would you please add a changelog entry and add a PR description?

cognifloyd avatar Apr 01 '22 20:04 cognifloyd

@cognifloyd changelog entry and description added. i don't know why the Lint check fails :(

Moradf90 avatar May 01 '22 16:05 Moradf90

This looks like a useful functionality, but it think it would make more sense / be more useful if this value could also be provided / overridden on action basis - making it an python runner parameter.

This way admin / pack author can specify limits on per action basis using immutable default parameter value.

Kami avatar May 01 '22 23:05 Kami

@Kami done :)

Moradf90 avatar May 02 '22 12:05 Moradf90

@Moradf90 Could you sign the CLA please?

cognifloyd avatar Jul 08 '22 16:07 cognifloyd

@Moradf90 Could you sign the CLA please?

I did

Moradf90 avatar Jul 14 '22 22:07 Moradf90

@Moradf90 Yes, I see that you have signed the CLA. I suspect your otorio.com email is not associated with your github account. The CLA assistant uses the email on each commit to see who has signed the CLA. Could you do one of:

cognifloyd avatar Jul 15 '22 03:07 cognifloyd