react-native-shadow-2 icon indicating copy to clipboard operation
react-native-shadow-2 copied to clipboard

Published 20 hours ago • verified publisher icon SrBrahma

fix: pixel gap from top and bottom in rtl mode

Open numandev1 opened this issue 2 years ago • 4 comments

fixed: https://github.com/SrBrahma/react-native-shadow-2/issues/28 reference https://github.com/SrBrahma/react-native-shadow-2/pull/61

https://snack.expo.dev/ssSCzEhwY here is a reproducible example for IOS RTL mode. this issue is fixed by my PR

numandev1 avatar May 08 '23 10:05 numandev1

Hi @numandev1, thanks for the contribution. This solution feels strange to me as the value 1 doesn't seem to take into consideration the device pixel ratio. I believe this solution only fixes the specific test case scenario .

ftzi avatar May 08 '23 11:05 ftzi

@SrBrahma i tested many devices in RTL mode and it is working for my all devices, you can also test it in RTL mode

numandev1 avatar May 08 '23 11:05 numandev1

fixed: #28 reference #61

https://snack.expo.dev/ssSCzEhwY here is a reproducible example for IOS RTL mode. this issue is fixed by my PR

this help for me

Programmeryos avatar May 15 '24 09:05 Programmeryos

Ty. I will merge this soon.

ftzi avatar May 15 '24 09:05 ftzi

Just released it under 7.1.0. The conflict was messy to solve so I changed the code directly. I am closing this, although the fix is applied to the code.

ftzi avatar May 26 '24 14:05 ftzi