Spxg

Results 36 comments of Spxg

> I guess it's unlikely that someone would call `:edit`, so it's not really a big deal. `:edit` is useful to re-edit the current file, when it has been changed...

> * Problem 1: open a file, and after the `inlay hints` are displayed, you can reproduce it through the `:edit` command. > * Problem 2: open a new file,...

> Same issue, when I delete a file or create a new file with `inlay hints` enabled, ![image](https://private-user-images.githubusercontent.com/17974631/299680986-017169cd-62d7-43cf-bd4c-92d553b72a15.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4Nzk1ODksIm5iZiI6MTcxMzg3OTI4OSwicGF0aCI6Ii8xNzk3NDYzMS8yOTk2ODA5ODYtMDE3MTY5Y2QtNjJkNy00M2NmLWJkNGMtOTJkNTUzYjcyYTE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDIzVDEzMzQ0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk0MjI3MzJjNTNkNWQxZTRhYjEzNGVjOGYzMzE3NWM0Yjc5NzE0MWZkZTI5MGRkODI0Nzg5YjRmMjg4MDc2MjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QNDpp6Dnfl9OKMZSrOX_-YCfW_IxPbBuTvMckt5p6Yk) It was fixed by https://github.com/neovim/neovim/pull/28461.

> I know nothing about wasm so we need to find someone kind enough to validate this PR. And would you mind adding a dedicated job, something like https://github.com/rusqlite/rusqlite/pull/1010/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R86 in...

> (a) https://github.com/Spxg/sqlite-wasm-rs/blob/master/sqlite-wasm-rs/sqlite-wasm/sqlite3.wasm comes from https://sqlite.org/2025/sqlite-wasm-3490000.zip ? (b) You don't use https://github.com/sqlite/sqlite/blob/master/ext/wasm/api/sqlite3-wasm.c ? (a) `sqlite3.wasm` is only used in `wrapper` feature, and the interface is exported through `wasm-bindgen`. The `sqlite3.wasm`...

The tests have been added to the CI/CD (approval is required to verify whether they work). All tests have passed in local testing. The `rusqlite_test_helper` library has been added to...

Fixed CI for `clippy` and `minimal versions`. The reduced coverage is probably because I added two wasm-only tests and some comments. By the way, why does the CI process require...

> Maybe because a patched / malicious `build.rs`, you can do anything ! Reasonable. I need to rerun CI now to verify whether everything passes. Can you approve it?

> > By the way, why does the CI process require approval? It seems that it is not convenient to find problems and fix CI. > > You can enable...

CI have passed: , cov failed because I didn’t have a token to upload. (thanks to @trevyn ) I'm ready for the review.