Sponge icon indicating copy to clipboard operation
Sponge copied to clipboard

[API-8] Forge Permission won't be checkt though Sponge Permission Plugins

Open Charismara opened this issue 4 years ago • 4 comments

I'm using a Mod which registers his Permission to the Forge PermissionAPI on a Sponge API 8 Server with LuckPerms and LuckPerms isn't able to grant Players the Permission to use the Mod Commands.

Charismara avatar Oct 28 '21 08:10 Charismara

Is that something we can get looked into? Forge removed the canUseCommand(String) method which sponge api 7 somehow catched to check perms for Forge only plugins(?). Only way to check for perms is the Perm api from Forge. We would have to have two seperate permission systems, one for sponge and one for Forge, on our server which is not gonna happen

johnfriedrich avatar Nov 05 '21 10:11 johnfriedrich

It will be looked into.

dualspiral avatar Nov 05 '21 10:11 dualspiral

I've looked into this a bit.

From what I can tell Forge has unhooked their permission handler (PermissionAPI) from loading in their own lifecycle. A revamp is also in progress for their system (see: https://github.com/MinecraftForge/MinecraftForge/pull/7780).

Unless we plan to re-hook forge's handling ourselves, probably best to wait until their revamp is finished to re-hook sponge. So don't expect it to return for API-8/1.16.

ItsDoot avatar Nov 23 '21 06:11 ItsDoot

As of December https://github.com/MinecraftForge/MinecraftForge/pull/7780 has been merged, so we can take a look at this again for API-9/1.18.

For the tracking issue for API-9, see: https://github.com/SpongePowered/Sponge/issues/3627

ItsDoot avatar Feb 11 '22 00:02 ItsDoot