ZendeskApi_v2 icon indicating copy to clipboard operation
ZendeskApi_v2 copied to clipboard

Add Support for UserFields in ZendeskApi_v2

Open ruannbotes opened this issue 1 year ago • 5 comments

Summary: This pull request adds support for managing UserFields within the ZendeskApi_v2 package. It includes both synchronous and asynchronous methods for CRUD operations on UserFields. The implementation aligns with the existing structure for managing TicketFields, ensuring consistency and ease of use.

Changes Include:

API Methods: Implemented sync and async methods for UserFields operations. Models: Added UserField, GroupUserFieldResponse, and IndividualUserFieldResponse models to represent UserFields and responses. Constants: Introduced UserFieldTypes constants for standardized handling of field types. Requests Update: Extended Users requests to support the new UserFields functionality. Unit Tests: Updated UsersTests to cover the new UserField methods, including both sync and async operations. Testing:

Added comprehensive unit tests to ensure proper functionality for all new methods. Tests include validation of input and output for the UserFields operations, ensuring they work as expected.

ruannbotes avatar Aug 20 '24 11:08 ruannbotes

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 20 '24 11:08 CLAassistant

Hi @mozts2005,

I can address the issues flagged by CodeFactor. However, the test failures in the pipeline seem to be related to invalid or expired secrets. The pipeline output shows the following error:

jsonException: {"error":"Couldn't authenticate you"}
2024-08-20T11:47:02.1169102Z ----> System.Net.WebException : The remote server returned an error: (401) Unauthorized.

It looks like the authentication details may need to be updated. Could you confirm if the secrets used in the pipeline are still valid?

Thanks!

ruannbotes avatar Aug 20 '24 18:08 ruannbotes

Yes, I will update the pipeline secret and rerun the test.

mozts2005 avatar Aug 20 '24 19:08 mozts2005

Hi @mozts2005,

I have resolved the CodeFactor issues, tests still failing due to authentication which I believe will be resolved with your secret update.

Thanks!

ruannbotes avatar Aug 21 '24 06:08 ruannbotes

Hi @mozts2005

Hope you doing well, just following on the pull request and pipeline secrets issue.

Thanks.

ruannbotes avatar Aug 26 '24 17:08 ruannbotes

Is there any movement on this? Or maybe a fork somewhere that has this already? I am stuck needing to update a user field and there's no support in the current version of the API. I either have to fork my own and add it myself following this PR, or I'm going to have to go raw http-request.

I'd really rather not a) Take on responsibility for yet another library OR b) Introduce another inconsistency by using a library for "all but one" call that I need to make to Zendesk.

MelGrubb avatar Nov 25 '24 20:11 MelGrubb