Laravel-Excel icon indicating copy to clipboard operation
Laravel-Excel copied to clipboard

(bug) skip unknown sheets on chunk reading fixes #4281

Open pusherman opened this issue 8 months ago • 2 comments

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change? Resolves the bug mentioned in #4281

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out. No

3️⃣ Does it include tests, if possible? No

4️⃣ Any drawbacks? Possible breaking changes? No

5️⃣ Mark the following tasks as done:

  • [x] Checked the codebase to ensure that your feature doesn't already exist.
  • [x] Take note of the contributing guidelines.
  • [x] Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • [x] Added tests to ensure against regression.

6️⃣ Thanks for contributing! 🙌

pusherman avatar Mar 20 '25 14:03 pusherman

@patrickbrouwers Hi, we need your approval on this, please merge this fix because it's really critical issue.

ismoil-nosr avatar May 02 '25 06:05 ismoil-nosr

This PR requires a unit test for me to able to look into this PR. Without it, I can't comfortably merge this.

patrickbrouwers avatar May 23 '25 11:05 patrickbrouwers

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

stale[bot] avatar Jul 26 '25 20:07 stale[bot]

I'll just delete this PR.

pusherman avatar Jul 26 '25 20:07 pusherman

If you don't plan on adding the requested unit test, I guess I won't have to reopen it then.

patrickbrouwers avatar Jul 27 '25 14:07 patrickbrouwers