Weather
Weather copied to clipboard
Sparker0i
Splash Screen
Good first issue for newbies.
Someone could implement the Splash screen GlobalActivity.java, which has the app icon and a spinner.
So GlobalActivity will need some refactoring:
- If the app is launched when city has not been set, it should redirect to the Enter City screen. Then the user will enter his city there and redirect to WeatherActivity
- If the app is launched after the city has been set, it should load the weather data (JSON) in the GlobalActivity itself, and then send this data to the WeatherFragment/WeatherActivity and display it there.
@Pl4gue You can do it! @Sparker0i I suggest to you to read the "Clean code" by Robert Cecil Martin :)
Yes
On 25-Oct-2017 2:20 AM, "Santhosh Kumar Munisamy" [email protected] wrote:
Is this still open?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Sparker0i/Weather/issues/27#issuecomment-339126831, or mute the thread https://github.com/notifications/unsubscribe-auth/AOSdWApkqV1ieG4Hiv3jIbZpNT3hYFNwks5svk2cgaJpZM4P6O07 .
Hi @ayush251196 I have added you as a collaborator. Please accept the invite so that I can assign this to you :)
java.lang.NullPointerException: Attempt to invoke virtual method 'void com.github.jorgecastilloprz.progressarc.ProgressArcView.show()' on a null object reference
That is unusual. How are you opening the WeatherActivity from the Splash Screen?
Actually, I changed my implementation. The error is not coming now. Please review my commit.
Once I downloaded the data or json in Global Activity how should I send it to other activity for populating the views?
Once I downloaded the data or json in Global Activity how should I send it to other activity for populating the views?
I'm sure there is a function in WeatherFragment which is used to render the data and display it. Go through the code and find that function. So once you finish loading the data in the splash screen, send it to the WeatherActivity, then while launching the WeatherFragment you can set this data inside a Bundle, then retrieve the data from it, then use the rendering function to display the data.
I have implemented the data loading in global activity but as data loading is so fast that the splash screen layout is hardly visible to the user. Within milliseconds the Weather activity gets started. Should I use a handler to delay the control flow so that user may be able to see the splash screen for 1 or 2 seconds.
as data loading is so fast that the splash screen layout is hardly visible to the user. Within milliseconds the Weather activity gets started.
Is this on a WiFi/4G Network?
I think because data is not that much huge, type of connectivity shall not affect data loading.
I think because data is not that much huge, type of connectivity shall not affect data loading.
Most of my user base is from 3G phones. I just want to know whether you are able to load the data in the splash screen and send it to the fragment or not?
`Nicely done. Just wanted to know where you extracted that splash screen icon from?
its in mipmap/ic_launcher_foreground
Please copy app/src/ic_launcher_x-web.png to the drawable folder and then use it
Might be. I also accepted another patch. Maybe from that too.
On the Enter City page (on first startup until entering default city), when we click on the location icon and go to the WeatherActivity, it crashes.
Even otherwise when undoing your commit, there were a few other bugs too. That is why I have reset master to the last working build, and all other progress from KWoC is safe in the um branch