matchbox icon indicating copy to clipboard operation
matchbox copied to clipboard

Ability to set marginBottom on LabelValue.Value.

Open shrirupa opened this issue 4 years ago • 2 comments

🚀 Feature request

Current Behavior

marginBottom cannot be set on LabelValue.Value. So it becomes difficult to handle mocks where the spacing is not default https://sparkpost.invisionapp.com/console/share/ZT2HZ5RVFB/607925652

Desired Behavior

marginBottom can be set on LabelValue.Value

Suggested Solution margin props can be passed to LabelValue.Value

Who does this impact? Who is this for?

To handle mocks where the spacing is not default https://sparkpost.invisionapp.com/console/share/ZT2HZ5RVFB/607925652

shrirupa avatar Jun 23 '21 15:06 shrirupa

LabelValue accepts margin system props. What's the use case for adding it to LabelValue.Value? Not sure I see where two values are used

jonambas avatar Jul 02 '21 12:07 jonambas

@jonambas as in the above mocks if the spacing being used between value and label is not the default that matchbox sets, then there isn't a way to adjust that. I think I tried using Stack but that didn't work either.

shrirupa avatar Aug 19 '21 13:08 shrirupa