kafka-webview icon indicating copy to clipboard operation
kafka-webview copied to clipboard

Lets add warning log msgs when ignoring or overwriting user defined configuration values for deserializers

Open Crim opened this issue 6 years ago • 1 comments

The following two places we silently overwrite or ignore user supplied configuration properties for deserializers. For debugging purposes we should emit warnings when we either overwrite or ignore user supplied configuration options.

https://github.com/SourceLabOrg/kafka-webview/blob/master/kafka-webview-ui/src/main/java/org/sourcelab/kafka/webview/ui/manager/kafka/KafkaConsumerFactory.java#L130-L143

https://github.com/SourceLabOrg/kafka-webview/blob/master/kafka-webview-ui/src/main/java/org/sourcelab/kafka/webview/ui/manager/kafka/config/DeserializerConfig.java#L88-L93

Crim avatar Sep 22 '19 01:09 Crim

https://github.com/SourceLabOrg/kafka-webview/pull/193 Fixed this issue , kindly have a look

ramya-ramakrishna avatar Oct 30 '19 09:10 ramya-ramakrishna