react-sortablejs icon indicating copy to clipboard operation
react-sortablejs copied to clipboard

Version 2.0.0 released!

Open waynevanson opened this issue 5 years ago • 6 comments

We've released version 2.0 of the library! :cake:

This is a breaking change, so read the readme to understand the API before migrating.

We could've gone about releasing this a lot better, but there's definitely a better plan for next time.

Before 2.1.0, I want to address the following issues:

  • Migration Guide from 1.x to 2.x.
  • Clearer documentation.
  • Examples on website with code attached.
  • Testing.
  • Release as v2.x.x-alpha-x before a true semantic release.

If you already have react-sortable installed, update your package.json to read "react-sortablejs" : "^v2.0.0" and reinstall node_modules to see the effect.

There are still issues with MultiDrag amongst other things, but I'm working my way through any bugs as they come out. Thank you to those submitting helpful issues! :heart:

Enjoy this fine release. Issues and PR's welcome :)

waynevanson avatar Dec 17 '19 03:12 waynevanson

Hey good work - but will there be a proper migration guide? I was using "react-sortablejs": "^1.5.1", and a lot of stuff is now broken. :/ Can i still use plain JS without having to use Typescript? The readme is a bit contradictory about this

masbaehr avatar Dec 20 '19 21:12 masbaehr

@masbaehr Typescript is compiled to Javascript, so it's all just javascript. Typescript just gives us that beautiful intellisense. It's obviously my preference and I encourage all to use Typescript.

A lot of stuff is now broken because it is a major release and there is currently no migration guide. Create a simple list from the readme and you'll soon understand the differences.

waynevanson avatar Dec 22 '19 10:12 waynevanson

Hi,Can you provide more comprehensive 2.0 documentation?

PinelliaTime avatar Dec 24 '19 03:12 PinelliaTime

I see that the current version has been upgraded to 2.0 or above, but I want to use the 1.5.1 version. After yarn add, I find that this version cannot be used.

PinelliaTime avatar Dec 24 '19 03:12 PinelliaTime

You can do the following. Revert back to "react-sortablejs": "^1.5.1". Then for updating (I'm using ncu - you might look for a similar replacement). I'm now doing: ncu -u -x react-sortablejs to ignore this v2 update.

Just a note for you @waynevanson While i understand your enthusiasm about the v.2 release - and don't get me wrong. I'm happy that it is being developed further, but i think such a major breaking release should have been done on a separate project / repo. Especially if code-examples are not ready yet and there also seem to be some major bugs (e.g. the group dragging).

Basically there is :

  1. A need to crawl trough the code to migrate.
  2. Actually rewrite quite a lot of code.
  3. Do a lot of testing ;).

Again no "rant". Just maybe some considerations you might do if there will be another major release. ;)

masbaehr avatar Dec 29 '19 13:12 masbaehr

Can you provide more comprehensive 2.0 documentation.

@PinelliaTime What do you feel is missing?

@masbaehr Thank you for the feedback. I'll definitely take all this into consideration.

such a major breaking release should have been done on a separate project / repo

I did at some stage, but I wasn't getting enough feedback. I felt I needed direction and some help so I issued a major release. I honestly should've released it as v2.0.0-alpha1 but it's too late now. This is noted for future.

I'm still learning how to do so much. I only started learning to code Jan 2019 so it's expected that a few things will be missed.

Check out this updated issue #96 for what is on the menu.

waynevanson avatar Dec 29 '19 23:12 waynevanson