CBORCoding icon indicating copy to clipboard operation
CBORCoding copied to clipboard

Remove dependency on Half only where obsolete

Open dabrahams opened this issue 1 year ago • 2 comments

Description

This is just #21 but with Half still in use on x64 Macs. I need to remove the Half dependency in order to run on Windows but unfortunately x64 Macs (only!) don't support Float16.

Fixes #29 by avoiding https://github.com/SomeRandomiOSDev/Half/issues/16

Checklist

Ensure that your pull request has followed all the steps below:

  • [x] Code compilation.
  • [x] All tests passing.
  • [x] No new SwiftLint issues.
  • [x] Added new unit tests, if applicable.
  • [x] Extended the documentation (including README), if applicable.
  • [x] Updated version in CBORCoding.podspec following semver guidelines.
  • [x] Ran workflowtests.sh and passed.
  • [x] Added myself to the CONTRIBUTORS file.

workflowtests.sh fails, but it already fails for me on yourmain branch. I'll report a separate issue. I'm already in CONTRIBUTORS.md

Proposed changes

In addition to the motivation above, see #21.

dabrahams avatar Nov 13 '23 02:11 dabrahams

@dabrahams I created a release to address a lot of the issues that came up due to this repo being so out of date. Please rebase on this release and update this PR accordingly

SomeRandomiOSDev avatar Nov 14 '23 20:11 SomeRandomiOSDev

@SomeRandomiOSDev Rebasing is going to be tough. I'm just trying to get as far as making a merge work; I'm not an Xcode/carthage/cocoapods/whatever jock, so making all those parts work is a challenge for me. It's not clear whether you're willing to accept the minimum deployment targets advancing considerably in order to get Float16 supported, but that's what @christophhagen seems to have assumed and I'm following the same pattern.

dabrahams avatar Nov 16 '23 02:11 dabrahams