Maxime LUCE
Maxime LUCE
I'm following up on this PR. What approach do you prefer? 1/ Give users a prebuilt version of the runtime variant (to avoid code duplication on the developer side) 2/...
Good job, i can close this PR
Good changes, I have some feedbacks: 1. `getQueryClientContext` and `setQueryClientContext ` should not be exported in `index.ts` 2. `store.ts` is not needed anymore 3. `useQueryClient` should not be responsible of...
@sagiegurari, thank you for your reply. I understand your mean. However, it's not uncommon to see scripts that react to the `SIGINT` signal to clean their ressources. - eg: `telepresence`...
Hi everyone, Conditional compilation is a must-have feature in Typescript. The idea of both runtime et precompilation time constants is also a very good idea. But I think we should...
@stephanedr 1/ I agree with you, I edited my comment to remove `=` in define. 2/ I also agree with you, I edited my comment to add this exemple in...
Agree with @dbagley1. I add that all configuration options should have the scope `language-overridable`.
I can improve my type [MappedObservable](https://github.com/crissdev/knockout.mapping/blob/22dd4e45539507062b70ba368013d68c675faadf/types/knockout.mapping.d.ts#L5) using your improved version which is very good but I think that we can't use this type as the return type of the `fromJS`...
You're correct! I updated types to match this behavior.
@crissdev, any news?